End of the day they are all solid colours so any are good.
Black cars look awesome when clean
White cars are the colour of choice at present
A red car generally always looks tidy now paint pigment does not fade any more
silver dont show scratches as easily as any other colour
and steel grey is also friendly compared to keeping it clean when compared to black and white cars